Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented linter #17

Merged
merged 7 commits into from
Feb 19, 2023
Merged

Implemented linter #17

merged 7 commits into from
Feb 19, 2023

Conversation

harsh-siriah
Copy link
Contributor

This PR is regarding issue #4360

Linter has been implemented by taking inspiration from PR

@stnguyen90 stnguyen90 linked an issue Oct 13, 2022 that may be closed by this pull request
💄 Add Code Linter To ‘utopia-php/logger’ appwrite/appwrite#4360
Closed
4 tasks
Meldiron
Meldiron approved these changes Oct 18, 2022
View reviewed changes
Copy link
Contributor

@Meldiron Meldiron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 🎉

@christyjacob4
Copy link
Contributor

christyjacob4 commented Jan 10, 2023 •
edited
Loading

@harsh-siriah please resolve the conflicts

@christyjacob4 christyjacob4 merged commit bfc5eb4 into utopia-php:main Feb 19, 2023
@christyjacob4
Copy link
Contributor

THANK YOU! All changes merged 🥳

Please reach out to me on our Discord server if you would like to claim your Appwrite swags! As a way of saying thank you, we would also love to invite you to join the Appwrite organization on GitHub. Please share your GitHub username with us on Discord.  

You can accept the invite by visiting https://github.com/orgs/appwrite/invitation. By joining our team, you will officially be an Appwrite maintainer on GitHub.

You can change your membership visibility settings, so your new Appwrite team membership badge will show up on your personal GitHub profile.

Please feel free to look for more PRs you might be interested in helping with on our long list of Hacktoberfest friendly issues and help make Appwrite better :)

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Meldiron Meldiron Meldiron approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

💄 Add Code Linter To ‘utopia-php/logger’
3 participants
@harsh-siriah @christyjacob4 @Meldiron