Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix route mismatch against shorter paths when params are missing #96

Merged
merged 1 commit into from
May 30, 2023
Merged

Fix route mismatch against shorter paths when params are missing #96

merged 1 commit into from
May 30, 2023

Conversation

abnegate
Copy link
Member

What's Changed

  • Added a check to ensure that the matched URL has the same amount of segments (separated by /) as the route. This ensures that a URL will not match an incorrect route if parameters are missing.

Tests

  • Added new tests to ensure correct matching

@eldadfux eldadfux merged commit bc0144f into master May 30, 2023
@TorstenDittmann TorstenDittmann deleted the fix-route-mistmatch branch May 30, 2023 08:03
@stnguyen90 stnguyen90 linked an issue May 30, 2023 that may be closed by this pull request
🐛 Bug Report: Server sdk for node deleteFile api delete storage bucket instead of file. appwrite/appwrite#5310
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eldadfux eldadfux eldadfux approved these changes

@TorstenDittmann TorstenDittmann Awaiting requested review from TorstenDittmann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 Bug Report: Server sdk for node deleteFile api delete storage bucket instead of file.
2 participants
@abnegate @eldadfux