Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0.30.x #345

Merged
merged 23 commits into from
Nov 1, 2023
Merged

0.30.x #345

merged 23 commits into from
Nov 1, 2023

Conversation

christyjacob4
Copy link
Contributor

No description provided.

abnegate
abnegate reviewed Oct 29, 2023
View reviewed changes
Copy link
Member

@abnegate abnegate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's fix the tests too 👍

src/Database/Adapter.php Outdated Show resolved Hide resolved
src/Database/Adapter/MariaDB.php Show resolved Hide resolved
tests/Database/Adapter/MariaDBTest.php Outdated
Comment on lines 52 to 53

$database->create();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove this

@github-actions github-actions bot mentioned this pull request Nov 1, 2023
Closed
@abnegate abnegate merged commit 7dfb03e into main Nov 1, 2023
3 checks passed
@github-actions github-actions bot mentioned this pull request Dec 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abnegate abnegate abnegate approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@christyjacob4 @abnegate @Meldiron