Invalid Utf chars #339
Invalid Utf chars #339
Conversation
tests/Database/Base.php
Outdated
| @@ -1082,6 +1081,43 @@ public function testCreateDocumentDefaults(): void | |||
| static::getDatabase()->deleteCollection('defaults'); | |||
| } | |||
|
|
|||
| public function testInvalidUtfCharacters(): void | |||
There was a problem hiding this comment.
Can you add some comments about what's being tested through the function?
There was a problem hiding this comment.
Done 👍
I did not make any global changes in Utopia for this fix, but we should know there is a problem we should be aware when trying to insert non-utf chars , for next time this issue pops up we can suggest a fix.
There was a problem hiding this comment.
What's the exception in this case?
There was a problem hiding this comment.
I just wanted them to pass, to be aware of this issue, to alert it, and maybe later on add it in Utopia and not in the test
There was a problem hiding this comment.
Yep I just mean what's the exception message when it does throw?
There was a problem hiding this comment.
Ohh :)
The exception message varies between adapters I update the message in the tests, but with mariadb I can not since it includes namespaces which change, so I added the status code.
Good catch, did not realize Sqlite was passing, not sure what to do about it.
No description provided.