Initial Commit #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| */ | ||
| public function filter(string $value):string | ||
| { | ||
| $value = preg_replace("/[^A-Za-z0-9]_/", '', $value); |
There was a problem hiding this comment.
Can we avoid RegEx somehow?
The readability suffers alot and if there is a native method we could utilize, we might even get a performance boost (even though the impact is not worth mentioning).
There was a problem hiding this comment.
Yes, I like avoiding regex, let me see if I can come up with something effective.
kodumbeats
reviewed
May 10, 2021
TorstenDittmann
approved these changes
May 13, 2021
lohanidamodar
approved these changes
May 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.