Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hazelcast Adpater added, closes #3973 #28

Merged

Conversation

kaggrwal
Copy link

@kaggrwal kaggrwal commented Oct 18, 2022

Hazelcast Adpater added, closes #issue

Copy link
Contributor

@stnguyen90 stnguyen90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR! 🤯 We left some comments during the review, please check them out.

Would you please also fix the lining errors?

phpunit.xml Outdated Show resolved Hide resolved
tests/Cache/HazelCastTest.php Outdated Show resolved Hide resolved
tests/Cache/HazelCastTest.php Outdated Show resolved Hide resolved
@stnguyen90 stnguyen90 marked this pull request as draft October 28, 2022 20:43
@kaggrwal kaggrwal marked this pull request as ready for review October 29, 2022 15:24
@kaggrwal
Copy link
Author

Hi @stnguyen90, I'm getting no issues when running lint on my local. I have attached the screenshot also.
Screenshot from 2022-10-30 21-38-59

@PineappleIOnic
Copy link
Member

Thank you so much for the PR 🤩. We're adding the hacktoberfest-accepted label to ensure this PR counts towards your Hacktoberfest contributions count. With that said, please stay active on this PR to address any comments once you receive a review. Happy Hacktoberfest! 🎃

Copy link
Contributor

@stnguyen90 stnguyen90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @stnguyen90, I'm getting no issues when running lint on my local. I have attached the screenshot also.

@kaggrwal, running ./vendor/bin/pint will actually fix your code so that's why running ./vendor/bin/pint --test after passes. You probably have code you haven't committed or pushed.

Copy link
Contributor

@stnguyen90 stnguyen90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work on your PR! We've approved your work and it'll be merged soon!

@kaggrwal
Copy link
Author

@stnguyen90 Please merge it, as it's been pending since long time.

@christyjacob4 christyjacob4 merged commit 5c7e7fe into utopia-php:master Dec 20, 2022
@christyjacob4
Copy link
Contributor

THANK YOU! All changes merged 🥳

Please reach out to me on our Discord server if you would like to claim your Appwrite swags! As a way of saying thank you, we would also love to invite you to join the Appwrite organization on GitHub. Please share your GitHub username with us on Discord.  

You can accept the invite by visiting https://github.com/orgs/appwrite/invitation. By joining our team, you will officially be an Appwrite maintainer on GitHub.

You can change your membership visibility settings, so your new Appwrite team membership badge will show up on your personal GitHub profile.

Please feel free to look for more PRs you might be interested in helping with on our long list of Hacktoberfest friendly issues and help make Appwrite better :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🎯 Enrich Appwrite Caching with Hazelcast IMDG Adapter
4 participants