Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sharefilemodifier: take ShareItem as input, not function #3469

Merged
merged 1 commit into from
Jan 12, 2022
Merged

sharefilemodifier: take ShareItem as input, not function #3469

merged 1 commit into from
Jan 12, 2022

Conversation

ktprograms
Copy link
Contributor

Forgot to do this in #3056

@osy
Copy link
Contributor

osy commented Jan 12, 2022

Can you explain why this change is needed?

@ktprograms
Copy link
Contributor Author

It makes the code cleaner by passing an instance of ShareItem instead of a function that creates a ShareItem

@ktprograms
sharefilemodifier: take ShareItem as input, not function
2dcebd2 
Also remove unneeded `import UniformTypeIdentifiers` from
`SavePanel.swift` (it's imported by SwiftUI already),
and fix incorrect use of `it's` in comment in `SavePanel.swift`
@osy osy merged commit f9eb0c0 into utmapp:master Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osy osy osy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ktprograms @osy