Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Establish ADRs and Document Public Event Calendar Management for OSCAL Team #1638

Merged
merged 8 commits into from
Feb 21, 2023
Merged

Establish ADRs and Document Public Event Calendar Management for OSCAL Team #1638

merged 8 commits into from
Feb 21, 2023

Conversation

aj-stein-nist
Copy link
Contributor

@aj-stein-nist aj-stein-nist commented Feb 6, 2023 •
edited
Loading

Committer Notes

Relates to #1408.

All Submissions:

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?
  • Have you updated all OSCAL website and readme documentation affected by the changes you made? Changes to the OSCAL website can be made in the docs/content directory of your branch.

@aj-stein-nist aj-stein-nist self-assigned this Feb 6, 2023
@aj-stein-nist aj-stein-nist force-pushed the 1408-rfc-add-a-calendar-feed-for-nist-oscal-events-to-oscal-site branch from 2f4632b to b48b4b5 Compare February 6, 2023 22:50
@aj-stein-nist aj-stein-nist added Discussion Needed This issues needs to be reviewed by the OSCAL development team. Scope: Documentation This issue relates to OSCAL documentation. labels Feb 6, 2023
@aj-stein-nist aj-stein-nist force-pushed the 1408-rfc-add-a-calendar-feed-for-nist-oscal-events-to-oscal-site branch from 340d7c2 to b723bb5 Compare February 7, 2023 17:00
@aj-stein-nist aj-stein-nist requested a review from a team February 7, 2023 17:08
@aj-stein-nist aj-stein-nist marked this pull request as ready for review February 7, 2023 17:08
Compton-US
Compton-US previously approved these changes Feb 7, 2023
View reviewed changes
@aj-stein-nist
Copy link
Contributor Author

Hmmm, it seems I dismissed the review and made it stale automatically. Note to self: how to look into reconfiguring that behavior in GH to reduce lag time on all PRs.

This was referenced Feb 7, 2023
Closed
Merged
Closed
nikitawootten-nist
nikitawootten-nist requested changes Feb 16, 2023
View reviewed changes
Copy link
Contributor

@nikitawootten-nist nikitawootten-nist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content looks good, but the name of the file is incorrect.

decisions/0002-record-architecture-decisions.md Outdated Show resolved Hide resolved
wendellpiez
wendellpiez previously approved these changes Feb 16, 2023
View reviewed changes
Copy link
Contributor

@wendellpiez wendellpiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work so far. (Not expecting perfection just yet.)

decisions/0002-record-architecture-decisions.md Outdated Show resolved Hide resolved
iMichaela
iMichaela requested changes Feb 16, 2023
View reviewed changes
Copy link
Contributor

@iMichaela iMichaela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see the comments suggesting rewording and also the concern regarding the process.

decisions/0002-record-architecture-decisions.md Outdated Show resolved Hide resolved
Compton-US
Compton-US previously approved these changes Feb 16, 2023
View reviewed changes
iMichaela
iMichaela approved these changes Feb 17, 2023
View reviewed changes
Copy link
Contributor

@iMichaela iMichaela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nikitawootten-nist
nikitawootten-nist approved these changes Feb 21, 2023
View reviewed changes
Copy link
Contributor

@nikitawootten-nist nikitawootten-nist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

JustKuzya
JustKuzya approved these changes Feb 21, 2023
View reviewed changes
Copy link
Contributor

@JustKuzya JustKuzya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objections or corrections on my end - simple edits

wendellpiez
wendellpiez approved these changes Feb 21, 2023
View reviewed changes
Copy link
Contributor

@wendellpiez wendellpiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks AJ

@aj-stein-nist aj-stein-nist merged commit 4df08f9 into usnistgov:main Feb 21, 2023
aj-stein-nist added a commit to aj-stein-nist/OSCAL-forked that referenced this pull request Feb 28, 2023
@aj-stein-nist
Woops, mark ADRs approved.
929e8a4 
I missed these in usnistgov#1638 as part of usnistgov#1408. As it pertains to the calendar
management work, might as well touch this up as well.
@aj-stein-nist aj-stein-nist mentioned this pull request Feb 28, 2023
Merged
7 tasks
aj-stein-nist added a commit that referenced this pull request Feb 28, 2023
@aj-stein-nist
Fix Missing Header for Events Page and Mark ADRs Actually Approved (#…
cbeff74 
…1677)

* Woops, fix missing headers for #1408.

* Woops, mark ADRs approved.

I missed these in #1638 as part of #1408. As it pertains to the calendar
management work, might as well touch this up as well.
nikitawootten-nist pushed a commit that referenced this pull request Apr 10, 2023
@aj-stein-nist @wendellpiez @nikitawootten-nist
Establish ADRs and Document Public Event Calendar Management for OSCA…
5dc03cf 
…L Team (#1638)

* Add ADR structure for #1408.

* Add decision record for use of shared calendar for #1408

* Take wording suggestion from @Compton-NIST.

Co-authored-by: Chris Compton <[email protected]>

* Integrate feedback into ADR 2 from @iMichaela.

* Update decisions/0002-record-architecture-decisions.md

Co-authored-by: Wendell Piez <[email protected]>

* Update decisions/0002-record-architecture-decisions.md

* Rename file per @nikitawooten-nist's feedback.

* Update decisions/0002-communicating-nist-oscal-events-to-the-public.md

---------

Co-authored-by: Chris Compton <[email protected]>
Co-authored-by: Wendell Piez <[email protected]>
nikitawootten-nist pushed a commit that referenced this pull request Apr 10, 2023
@aj-stein-nist @nikitawootten-nist
Fix Missing Header for Events Page and Mark ADRs Actually Approved (#…
5cd4f58 
…1677)

* Woops, fix missing headers for #1408.

* Woops, mark ADRs approved.

I missed these in #1638 as part of #1408. As it pertains to the calendar
management work, might as well touch this up as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Compton-US Compton-US Compton-US approved these changes

@nikitawootten-nist nikitawootten-nist nikitawootten-nist approved these changes

@iMichaela iMichaela iMichaela approved these changes

@JustKuzya JustKuzya JustKuzya approved these changes

@wendellpiez wendellpiez wendellpiez approved these changes

@Arminta-Jenkins-NIST Arminta-Jenkins-NIST Awaiting requested review from Arminta-Jenkins-NIST

Assignees

@aj-stein-nist aj-stein-nist

Labels
Discussion Needed This issues needs to be reviewed by the OSCAL development team. Scope: Documentation This issue relates to OSCAL documentation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@aj-stein-nist @wendellpiez @JustKuzya @iMichaela @nikitawootten-nist @Compton-US