Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic validation for variable names #3676

Merged
merged 2 commits into from
Mar 14, 2024
Merged

Basic validation for variable names #3676

merged 2 commits into from
Mar 14, 2024

Conversation

CGoodwin90
Copy link
Contributor

General Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated
  • PR title is ready for inclusion in changelog

Database Migrations

  • If your PR contains a database migation, it MUST be the latest in date order alphabetically

Currently the api allows for empty variables names & leading/trailing spaces - this provides basic validation for empty variable names and trims whitespace.

closes #3665

@tobybellwood tobybellwood modified the milestones: 2.19.0, 2.18.0 Mar 13, 2024
@CGoodwin90 CGoodwin90 marked this pull request as ready for review March 14, 2024 00:47
Copy link
Member

@tobybellwood tobybellwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straightforward enough, LGTM

@tobybellwood tobybellwood merged commit ea68320 into main Mar 14, 2024
1 check passed
@tobybellwood tobybellwood deleted the trim-env-names branch March 25, 2024 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trim environment variable names
2 participants