feat: support changing more settings in keycloak #3497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobybellwood
force-pushed
the
keycloak-email-realm-settings
branch
from
e2b2876
to
d3ca33b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
This adds the ability to configure additional realm settings easily using json files, and also set the admin user email address which seems to be required for configuring email.
There does exist an existing way to apply realm settings using an envvar, but it is cumbersome. This new way allows helm to create a configmap to then volumemount to the required location and be consumed.
I've separated out the smtp configuration to its own step so that the email configuration can be provided separately to other realm settings easily, but they still use the same endpoint in the end.