Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: nack messages that encounter error to resubmit #3489

Merged
merged 1 commit into from
Jul 28, 2023

Conversation

shreddedbacon
Copy link
Member

@shreddedbacon shreddedbacon commented Jul 26, 2023

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated
  • PR title is ready for inclusion in changelog

This fixes the action-handler so that it will use nack on messages that need to resubmit to the queue for processing if there is an error in the Lagoon API

@shreddedbacon shreddedbacon force-pushed the actions-handler-queue-error branch 2 times, most recently from a75c620 to 337498d Compare July 26, 2023 21:46
@shreddedbacon shreddedbacon marked this pull request as ready for review July 26, 2023 23:18
@shreddedbacon shreddedbacon added this to the 2.15.4 milestone Jul 26, 2023
Copy link
Member

@tobybellwood tobybellwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested as working

@tobybellwood tobybellwood merged commit 6012459 into main Jul 28, 2023
1 check passed
@tobybellwood tobybellwood deleted the actions-handler-queue-error branch July 28, 2023 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants