fix: only update deployment fields if they are provided by remote-controller #3449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreddedbacon
changed the title
shreddedbacon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Minor fix that will only update the remoteid of a deployment if it is provided. In most cases the remote-controller will send this. But if an old build is cancelled, it can't determine the remoteid (because the pod or the build resource may have been deleted from the cluster a long time ago) so it doesn't provide the remoteid
This remoteid is used by the logs retrieval, and when a long time removed build is cancelled via the ui/api, it removes the remoteid which makes the logs inaccessible.
There is no reason to continually update the remoteid of a deployment once it has been set by the build.