Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update delete email notification #308

Merged
merged 1 commit into from
Dec 15, 2023
Merged

Conversation

tobybellwood
Copy link
Member

Previously the delete email notification command was unusable because of a copy/pasta error from the delete webhook notifiction

tobybellwood@pop-os:~$ lagoon delete notification email -n example-email
Error: unknown shorthand flag: 'n' in -n
Usage:
  lagoon delete notification [command]

Aliases:
  notification, n

Available Commands:
  microsoftteams         Delete a Microsoft Teams notification from Lagoon
  project-email          Delete a email notification from a project
  project-microsoftteams Delete a Microsoft Teams notification from a project
  project-rocketchat     Delete a RocketChat notification from a project
  project-slack          Delete a Slack notification from a project
  project-webhook        Delete a webhook notification from a project
  rocketchat             Delete a RocketChat notification from Lagoon
  slack                  Delete a Slack notification from Lagoon
  webhook                Delete a email notification from Lagoon
  webhook                Delete a webhook notification from Lagoon

This PR fixes the email subcommand, and regens the correct docs.

Copy link
Member

@shreddedbacon shreddedbacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find :D

@shreddedbacon shreddedbacon merged commit 3887317 into main Dec 15, 2023
4 checks passed
@shreddedbacon shreddedbacon deleted the delete_email_notification branch December 15, 2023 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants