Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sonar Code Coverage badge #341

Merged

Conversation

alexsoble
Copy link

@alexsoble alexsoble commented May 17, 2019

👋 Hi there! My name is Alex Soble, I'm an engineer with 18F. I'm part of an 18F team that has been working with Denver's ATCMTD program on their Connected Vehicle work.

I was taking a look at this project earlier today, starting with the test suite. I poked around the Travis build logs looking for code coverage stats, and then ultimately found them in the Sonar Cloud UI.

This PR adds the Sonar Cloud Code Coverage badge to the top of the README, so that developers learning more about the ITS ODE can see information about code coverage in their first glance.

Cheers and thank you for considering this pull request!

Copy link
Contributor

@mvs5465 mvs5465 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Alex, thanks for contributing! Nice touch, approved.

@alexsoble
Copy link
Author

@mvs5465 Thanks!

@mvs5465 mvs5465 changed the base branch from master to dev May 17, 2019 21:35
@mvs5465
Copy link
Contributor

mvs5465 commented May 17, 2019

Changed base to dev, will promote to master in next release.

@hmusavi hmusavi merged commit 2452b84 into usdot-jpo-ode:dev May 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants