Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crc conversion problems #294

Merged
merged 6 commits into from
Jan 16, 2019
Merged

Fix crc conversion problems #294

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
101ac4b
Fix crc conversion problems
Schwartz-Matthew-bah Jan 15, 2019
541ec48
Switch to mandating the input be hex
Schwartz-Matthew-bah Jan 15, 2019
92b38ce
Update swagger doc
Schwartz-Matthew-bah Jan 15, 2019
2ffee51
remove added unit test
Schwartz-Matthew-bah Jan 15, 2019
6046a5d
Minor grammar
Schwartz-Matthew-bah Jan 15, 2019
7c68de5
Fix unit tests
Schwartz-Matthew-bah Jan 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Switch to mandating the input be hex
  • Loading branch information
@Schwartz-Matthew-bah
Schwartz-Matthew-bah committed Jan 15, 2019
commit 541ec4827715e0f7658c363694ffac5ea129637c
7 changes: 0 additions & 7 deletions ...java/us/dot/its/jpo/ode/plugin/j2735/builders/TravelerMessageFromHumanToAsnConverter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@
import us.dot.its.jpo.ode.plugin.j2735.timstorage.DirectionOfUse.DirectionOfUseEnum;
import us.dot.its.jpo.ode.plugin.j2735.timstorage.DistanceUnits.DistanceUnitsEnum;
import us.dot.its.jpo.ode.plugin.j2735.timstorage.Extent;
import us.dot.its.jpo.ode.util.CodecUtils;
import us.dot.its.jpo.ode.util.CommonUtils;
import us.dot.its.jpo.ode.util.DateTimeUtils;
import us.dot.its.jpo.ode.util.JsonUtils;
Expand Down Expand Up @@ -408,12 +407,6 @@ public static void replaceMsgId(ObjectNode dataFrame) {
if (mutcdNode != null) {
roadSignID.set("mutcdCode", JsonUtils.newNode().put(mutcdNode.asText(), EMPTY_FIELD_FLAG));
}

// crc is optional
JsonNode crcNode = roadSignID.get("crc");
if (crcNode != null) {
roadSignID.put("crc", CodecUtils.toHex(CodecUtils.shortStringToByteArray(crcNode.asText())));
}
}
}
}
Expand Down