Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mixed ROS1 and ROS2 workspace #137

Merged
merged 5 commits into from
Sep 15, 2021
Merged

Conversation

msmcconnell
Copy link
Contributor

PR Details

Description

This PR updates the packages in this repo to support building in both a ROS1 and ROS2 environment. The individual packages are not made ROS1 and ROS2 compliant. Instead the ROS2 packages will only build in a ROS2 environment while the ROS1 packages will only build in a ROS1 environment. When in the unsupported environment the packages will log a message stating their compilation has been skipped.

Related Issue

Supports https://github.com/usdot-fhwa-stol/carma-platform/milestone/4

Motivation and Context

ROS2 version of carma-platform

How Has This Been Tested?

Build testing with switching between foxy and noetic

Types of changes

  • Defect fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • I have added any new packages to the sonar-scanner.properties file
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
    CARMA Contributing Guide
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@msmcconnell msmcconnell merged commit 371f543 into foxy/develop Sep 15, 2021
@msmcconnell msmcconnell deleted the alternative_msg_approach branch September 15, 2021 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant