112 - Replace UTF-8 quotes with ASCII quotes #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous quote marks were UTF-8 characters for left quote and right quote, resulting in the file being UTF-8 encoded. This causes file reading issues on environments with a non-UTF-8 locale (e.g., a POSIX locale). Replacing the UTF-8 quote marks with ASCII versions fixes the issue.
msmcconnell
approved these changes
Jun 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
Description
Fixes issue where the quotation marks in
LaneAttributesTrackedVehicle.msgwere UTF-8 characters. The UTF-8 characters resulted in reading issues on systems with a non-UTF-8 locale. The UTF-8 quotes have been replaced with ASCII quotes, which resolved the issue.Related Issue
Closes #112
Motivation and Context
The comment block in the
LaneAttributesTrackedVehicle.msgfile erroneously used UTF-8 quotation markings instead of ASCII quotes. This caused problems when a system (Docker container) using the POSIX locale tried to read the file. When the file was opened to generate the corresponding ROS message implementation, the build would crash because the quote marks could not be decoded.How Has This Been Tested?
j2735_msgspackage was built on a system using theen_US.UTF-8locale and a system using thePOSIXlocale. Both systems built the package successfully after the fix.Types of changes
Checklist:
CARMA Contributing Guide