Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Docker support #4

Merged
merged 3 commits into from
May 5, 2019
Merged

Add Docker support #4

merged 3 commits into from
May 5, 2019

Conversation

victor141516
Copy link
Contributor

Very basic Docker support.
You can run it easily with just:

URLHUM_APP_KEY=base64:UD4OwSyWXUL+QIMly8NzFe/gTCkdSDt9PfosDtX2PsI= docker-compose up

optiroot
optiroot requested changes May 3, 2019
View reviewed changes
Copy link
Member

@optiroot optiroot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you really so much!
This is something great.

Just one thing to point out: now UrlHum to install needs to run php artisan settings:set after all the installation and everything, as last command. Could you add it in Dockerfile on the 7th line?
Thanks.

@victor141516
Copy link
Contributor Author

victor141516 commented May 5, 2019 •
edited
Loading

Just updated it alongside some other improvements :)

@optiroot
Copy link
Member

optiroot commented May 5, 2019

Perfect! Thank you really so much. This is a great addition to the project!

Merging this.

@optiroot optiroot merged commit 69712b6 into urlhum:master May 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@optiroot optiroot optiroot requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@victor141516 @optiroot