Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make sure nitro runtime goes to one chunk #2547

Merged
merged 7 commits into from
Jun 19, 2024
Merged

fix: make sure nitro runtime goes to one chunk #2547

merged 7 commits into from
Jun 19, 2024

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Jun 19, 2024

(context: Reported by @atinux testing nitropack nightly against nuxt content module which has top level imports from #imports + nuxt renderer from #internal/nitro)

Nitro runtime can be imported with different ways #nitropack/runtime, #internal/nitro, #nitriopack/runtime/*. This makes rollup warning about manual chunks.

@pi0 pi0 self-assigned this Jun 19, 2024
@pi0 pi0 marked this pull request as draft June 19, 2024 16:26
@pi0 pi0 marked this pull request as ready for review June 19, 2024 16:33
@pi0 pi0 merged commit 8b4a408 into v2 Jun 19, 2024
5 checks passed
@pi0 pi0 deleted the fix/nitro-chunk branch June 19, 2024 16:44
@pi0 pi0 mentioned this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant