Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(iisnode): correctly escape backslashes for port fix #2020

Merged
merged 4 commits into from
Dec 25, 2023
Merged

Conversation

manniL
Copy link
Member

@manniL manniL commented Dec 22, 2023

πŸ”— Linked issue

nuxt/nuxt#22961

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Uses a more general fix than #1783 based on #1697

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@manniL manniL marked this pull request as ready for review December 22, 2023 19:32
@manniL manniL changed the title fix: use iis port as unix path if not a number fix(iisnode): use port as unix path if not a number Dec 22, 2023
@manniL manniL changed the title fix(iisnode): use port as unix path if not a number fix(iisnode): use port as unix path if exists and not a number Dec 22, 2023
src/presets/iis.ts Outdated Show resolved Hide resolved
@manniL manniL changed the title fix(iisnode): use port as unix path if exists and not a number fix(iisnode): correctly escape backslashes for port fix Dec 25, 2023
@manniL
Copy link
Member Author

manniL commented Dec 25, 2023

Updated the PR to simply escape the slashes correctly.

before:

        if (process.env.PORT.startsWith('\')) {
          process.env.NITRO_UNIX_SOCKET = process.env.PORT
          delete process.env.PORT
        }
        import('./server/index.mjs');

With this PR:

        if (process.env.PORT.startsWith('\\')) {
          process.env.NITRO_UNIX_SOCKET = process.env.PORT
          delete process.env.PORT
        }
        import('./server/index.mjs'); 

@manniL manniL requested a review from pi0 December 25, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing backslash in index.js file generated by iis preset
2 participants