Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wasm): directly generate chunk exports #2003

Merged
merged 6 commits into from
Dec 13, 2023
Merged

fix(wasm): directly generate chunk exports #2003

merged 6 commits into from
Dec 13, 2023

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Dec 13, 2023

πŸ”— Linked issue

#1952

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

When annotating wasm (virtual) chunk dependencies with external: true, roll-up sometimes reverts them to the original external package as external in the bundle.

This PR uses a virtual module (non-externalized) + post-build transform to convert it to relative import to avoid rollup interfering.

Note: when option is enabled for iife/umd targets (cloudflare preset) the experimental module is still unsupported now with more explicit check.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pi0 pi0 marked this pull request as draft December 13, 2023 14:44
@pi0 pi0 marked this pull request as ready for review December 13, 2023 14:56
@pi0 pi0 merged commit a75258e into main Dec 13, 2023
5 checks passed
@pi0 pi0 deleted the fix/wasm-resolve branch December 13, 2023 15:01
@pi0 pi0 mentioned this pull request Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant