Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rollup): avoid preserving relative externals #1972

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Nov 30, 2023

πŸ”— Linked issue

resolves #1971

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This PR removes the custom configuration for makeAbsoluteExternalsRelative and uses new default "ifRelativeSource".

Some context of why we had this custom config before:

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pi0 pi0 marked this pull request as ready for review November 30, 2023 14:33
@pi0 pi0 merged commit cbb44d5 into main Nov 30, 2023
5 checks passed
@pi0 pi0 deleted the rollup/relative-externals branch November 30, 2023 14:33
@pi0 pi0 mentioned this pull request Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

realative wasm imports not resolving properly
1 participant