Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support inline mode for serveStatic #1864

Merged
merged 3 commits into from
Oct 28, 2023
Merged

feat: support inline mode for serveStatic #1864

merged 3 commits into from
Oct 28, 2023

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Oct 28, 2023

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Extracted from #1863.

This new mode allows for edge conditions that it is only possible to serve static assets using their inline value.

Also makes refactors for future improvements in public asset plugin.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pi0 pi0 added the enhancement New feature or request label Oct 28, 2023
@codecov
Copy link

codecov bot commented Oct 28, 2023

Codecov Report

Merging #1864 (75d6aa1) into main (923b6cd) will decrease coverage by 0.04%.
The diff coverage is 74.35%.

❗ Current head 75d6aa1 differs from pull request most recent head 077b445. Consider uploading reports for the commit 077b445 to get more accurate results

@@            Coverage Diff             @@
##             main    #1864      +/-   ##
==========================================
- Coverage   52.34%   52.31%   -0.04%     
==========================================
  Files         172      172              
  Lines       11882    11910      +28     
  Branches      910      908       -2     
==========================================
+ Hits         6220     6231      +11     
- Misses       5566     5582      +16     
- Partials       96       97       +1     
Files Coverage Ξ”
src/types/nitro.ts 100.00% <100.00%> (ΓΈ)
src/rollup/plugins/public-assets.ts 88.07% <73.68%> (-4.61%) ⬇️

... and 2 files with indirect coverage changes

@pi0 pi0 merged commit 0cca7c9 into main Oct 28, 2023
6 checks passed
@pi0 pi0 deleted the feat/inline-static branch October 28, 2023 22:22
@pi0 pi0 mentioned this pull request Nov 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant