fix(renderer): check full path for /favicon.ico placeholder (#2553)

unjs · Jun 21, 2024 · b86bb45 · b86bb45
1 parent f76d21b
commit b86bb45
Show file tree

Hide file tree

Showing 7 changed files with 43 additions and 1 deletion.
diff --git a/examples/renderer/api/hello.ts b/examples/renderer/api/hello.ts
@@ -0,0 +1 @@
+export default defineEventHandler(() => "Nitro is amazing!");
diff --git a/examples/renderer/nitro.config.ts b/examples/renderer/nitro.config.ts
@@ -0,0 +1,4 @@
+export default defineNitroConfig({
+ compatibilityDate: "2024-06-21",
+ renderer: "~/renderer",
+});
diff --git a/examples/renderer/package.json b/examples/renderer/package.json
@@ -0,0 +1,11 @@
+{
+ "name": "example-renderer",
+ "private": true,
+ "scripts": {
+ "dev": "nitro dev",
+ "build": "nitro build"
+ },
+ "devDependencies": {
+ "nitropack": "latest"
+ }
+}
diff --git a/examples/renderer/renderer.ts b/examples/renderer/renderer.ts
@@ -0,0 +1,15 @@
+import { defineRenderHandler } from "nitropack/runtime";
+
+export default defineRenderHandler((_event) => {
+ return {
+ body: /* html */ `<!DOCTYPE html>
+ <html>
+ <head>
+ <title>Rendered Page</title>
+ </head>
+ <body>
+ <h1>Rendered by Nitro!</h1>
+ </body>
+ </html>`,
+ };
+});
diff --git a/examples/renderer/tsconfig.json b/examples/renderer/tsconfig.json
@@ -0,0 +1,3 @@
+{
+ "extends": "./.nitro/types/tsconfig.json"
+}
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/src/runtime/internal/renderer.ts b/src/runtime/internal/renderer.ts
@@ -9,11 +9,13 @@ import {
 } from "h3";
 import type { RenderHandler } from "nitropack/types";
 import { useNitroApp } from "./app";
+import { useRuntimeConfig } from "./config";
 
 export function defineRenderHandler(handler: RenderHandler) {
+ const runtimeConfig = useRuntimeConfig();
  return eventHandler(async (event) => {
  // TODO: Use serve-placeholder
- if (event.path.endsWith("/favicon.ico")) {
+ if (event.path === `${runtimeConfig.app.baseURL}favicon.ico`) {
  setResponseHeader(event, "Content-Type", "image/x-icon");
  return send(
  event,