Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: normalize fetch headers #82

Merged
merged 5 commits into from
Feb 17, 2023
Merged

fix: normalize fetch headers #82

merged 5 commits into from
Feb 17, 2023

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Feb 17, 2023

resolves #81

Fixing couple of issues to normalize headers (lowercase and remove undefined values). CI seems fixing (locally it was working for me on 16 too not sure why...)

@codecov
Copy link

codecov bot commented Feb 17, 2023

Codecov Report

Merging #82 (02ebb22) into main (af23a7d) will increase coverage by 0.65%.
The diff coverage is 74.62%.

@@            Coverage Diff             @@
##             main      #82      +/-   ##
==========================================
+ Coverage   70.00%   70.65%   +0.65%     
==========================================
  Files           6        6              
  Lines         310      426     +116     
  Branches       42       48       +6     
==========================================
+ Hits          217      301      +84     
- Misses         93      125      +32     
Impacted Files Coverage Δ
src/registry.ts 35.00% <29.16%> (-4.14%) ⬇️
src/providers.ts 44.11% <33.33%> (-2.44%) ⬇️
src/_utils.ts 74.43% <81.53%> (+4.66%) ⬆️
src/giget.ts 82.46% <89.04%> (+1.59%) ⬆️
src/types.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pi0 pi0 changed the title investigating #81 fix: normalize fetch headers Feb 17, 2023
@pi0 pi0 marked this pull request as ready for review February 17, 2023 13:54
@pi0 pi0 merged commit ec2b98d into main Feb 17, 2023
@pi0 pi0 deleted the chore/check-ci branch February 17, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

downloadTemplate broken since last update
1 participant