Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(guide): add information about static parameters. #80

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

amandesai01
Copy link
Contributor

πŸ”— Linked issue

Resolves #77

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This pull request adds information on using Static Parameters.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@amandesai01
Copy link
Contributor Author

I have added text as per my understanding and would suggest maintainers to update as per requirement.

@amandesai01
Copy link
Contributor Author

@pi0 are you going to merge this? I see fair amount of people using string literals for tablename and getting into issues.

@hareland
Copy link
Contributor

This should be documented -> Is it possible to approve this PR @pi0 ?

docs/1.guide/1.index.md Outdated Show resolved Hide resolved
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ❀️

@pi0 pi0 changed the title docs(guide): Add information about static parameters. docs(guide): add information about static parameters. Oct 9, 2024
@pi0 pi0 merged commit ad84a26 into unjs:main Oct 9, 2024
2 checks passed
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Please upload report for BASE (main@d3b3028). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #80   +/-   ##
=======================================
  Coverage        ?   29.90%           
=======================================
  Files           ?       15           
  Lines           ?      515           
  Branches        ?       43           
=======================================
  Hits            ?      154           
  Misses          ?      354           
  Partials        ?        7           

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

can't pass table name from variable without {}
3 participants