-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix FixedDecimal rounding bug; add more tests #3644
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manishearth
previously approved these changes
Jul 6, 2023
cc @eggrobin who was also observing interestingly as I was poking at this failure |
I went ahead and refactored the logic of the |
Manishearth
previously approved these changes
Jul 7, 2023
younies
previously approved these changes
Jul 7, 2023
younies
approved these changes
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Numbers with interior zeros were expanding at too high a magnitude. For example, consider the input
1.108
expanded at position -2.Old behavior:
1.10
(digits list110
)11
)1.20
New behavior:
1.10
(digits list110
)1.11
I had the individual failing input from @Manishearth, but I had to write some elaborate test cases before I could reproduce the problem from "first principles". Since I was able to do that, I'm confident that this change fixes the problem across all rounding modes.