Support Deserialization for VarZeroVec<VarZeroSlice>
#3643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertbastian
approved these changes
Jul 7, 2023
Manishearth
approved these changes
Jul 7, 2023
Manishearth
added a commit
to Manishearth/icu4x
that referenced
this pull request
Jul 7, 2023
…de-org#3643)" This reverts commit b2a1b79.
Manishearth
added a commit
that referenced
this pull request
Jul 10, 2023
sffc
reviewed
Jul 11, 2023
There was a problem hiding this comment.
Just pulling out the actual impls:
impl<'de, 'a, T, F> Deserialize<'de> for VarZeroVec<'a, T, F>
impl<'de, 'a, T, F> Deserialize<'de> for &'a VarZeroSlice<T, F>
impl<'de, 'a, T, F> Deserialize<'de> for Box<VarZeroSlice<T, F>>
Those look like the correct Serde impls to me. LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was previously unsupported (see first commit).
cc @Manishearth
There might be an easier way? As a warning, this was difficult to figure out, because an inferred type (on
let visitor =) caused a difficult to understand type checking overflow error. Adding type annotations fixed that.