Add ZeroVec::owned_capacity #3431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manishearth
approved these changes
May 13, 2023
| /// assert_eq!(zv.owned_capacity(), Some(8.try_into().unwrap())); | ||
| /// ``` | ||
| #[inline] | ||
| pub fn owned_capacity(&self) -> Option<NonZeroUsize> { |
There was a problem hiding this comment.
thought: I think having the method be .capacity() and returning an integer is also fine, "Borrowed is zero capacity" is a consistent and sensical statement, and generally useful. (if most people are going to unwrap_or(0) this API, might as well)
but not opposed to this
There was a problem hiding this comment.
I wanted to be more type-safe and explicit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding some code from a branch.