Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add const litemap getter functions for common types #3416

Merged
merged 6 commits into from
May 8, 2023
Merged

Add const litemap getter functions for common types #3416

merged 6 commits into from
May 8, 2023

Conversation

sffc
Copy link
Member

@sffc sffc commented May 7, 2023

I wanted to use these so I added them.

@sffc sffc requested a review from Manishearth as a code owner May 7, 2023 04:35
Manishearth
Manishearth previously approved these changes May 7, 2023
View reviewed changes
Copy link
Member

@Manishearth Manishearth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: probably mention in the docs why these are separate functions

(and say that once we have const trait behavior we can coalesce them)

@sffc sffc merged commit defa43e into unicode-org:main May 8, 2023
@sffc sffc deleted the const-litemap branch May 8, 2023 23:45
@Manishearth Manishearth mentioned this pull request Sep 21, 2023
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Manishearth Manishearth Manishearth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sffc @Manishearth