Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICU-21757 Stop sharing utilities-for-cldr #2997

Merged
merged 1 commit into from May 6, 2024
Merged

ICU-21757 Stop sharing utilities-for-cldr #2997

merged 1 commit into from May 6, 2024

Conversation

mihnita
Copy link
Contributor

@mihnita mihnita commented May 6, 2024 •
edited by markusicu

... and move UnicodeMap & friends to ICU4J core in package com.ibm.icu.impl

Checklist
  • Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-21757
  • Required: The PR title must be prefixed with a JIRA Issue number.
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number.
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

@mihnita mihnita requested review from echeran and markusicu May 6, 2024 20:45
@mihnita
ICU-21757 Stop sharing utilities-for-cldr
17a8deb 
Moves UnicodeMap and related classes to core.
Also removes `CollectionUtilities`, `UOption`, and `ElapsedTimer`.
They will end up in UnicodeTools, CLDR, and CLDR respectively.
@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@markusicu
Copy link
Member

@eggrobin @macchiati FYI -- Mihai will adjust CLDR & Unicode Tools code in follow-up PRs.

@mihnita mihnita merged commit 9369b7a into unicode-org:main May 6, 2024
81 checks passed
@mihnita mihnita deleted the mihai_unicode_map branch May 8, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markusicu markusicu markusicu approved these changes

@echeran echeran Awaiting requested review from echeran

@yumaoka yumaoka Awaiting requested review from yumaoka

@pedberg-icu pedberg-icu Awaiting requested review from pedberg-icu

@DraganBesevic DraganBesevic Awaiting requested review from DraganBesevic

Assignees

@echeran echeran

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@mihnita @markusicu @echeran