Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICU-22721 Rename scoped variable to not shadow variable in outer scope #2976

Merged
merged 1 commit into from May 14, 2024
Merged

ICU-22721 Rename scoped variable to not shadow variable in outer scope #2976

merged 1 commit into from May 14, 2024

Conversation

roubert
Copy link
Member

@roubert roubert commented Apr 19, 2024

Checklist
  • Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22721
  • Required: The PR title must be prefixed with a JIRA Issue number.
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number.
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

@roubert roubert requested a review from echeran April 19, 2024 16:34
echeran
echeran approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@echeran echeran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roubert roubert merged commit ed52e0a into unicode-org:main May 14, 2024
97 checks passed
@roubert roubert deleted the 22721-shadow branch May 14, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@echeran echeran echeran approved these changes

Assignees

@echeran echeran

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@roubert @echeran