Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICU-22724 ICU BRS 76: front-load update version to 76.0.1 #2974

Merged
merged 1 commit into from Apr 18, 2024

Conversation

mihnita
Copy link
Contributor

@mihnita mihnita commented Apr 18, 2024

Checklist
  • Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22724
  • Required: The PR title must be prefixed with a JIRA Issue number.
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number.
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

@mihnita mihnita requested a review from sffc April 18, 2024 22:55
@sffc
Copy link
Member

sffc commented Apr 18, 2024

From https://unicode-org.github.io/icu/processes/release/tasks/versions.html

Did you do this?

SINCE ICU 68
In tools/cldr/cldr-to-icu/build-icu-data.xml edit <property name="icuVersion" value="67.1.0.0"/> and <property name="icuDataVersion" value="67.1.0.0"/>.

And this?

icu4j/main/core/src/main/java/com/ibm/icu/util/VersionInfo.java

There is a static block starting at line 501 (as of 54.1) in the source file.

Update the ICU_VERSION value, where the first three arguments represent the major, minor, and patch versions of a semantic version.

And these?

icu4j/main/shared/build/common.properties

icu4j/build.properties (For API change report and release target)

The rest of the changes look correct.

@sffc
Copy link
Member

sffc commented Apr 18, 2024

Verified that the files are in the branch, I just didn't find them the first time amongst the 4000 other files.

@mihnita
Copy link
Contributor Author

mihnita commented Apr 18, 2024

Thank you very much for the quick review,
and for being thorough
M

@mihnita mihnita merged commit 0e4c2d8 into unicode-org:main Apr 18, 2024
103 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants