Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICU-22549 Add DateTimePatternGenerator fuzzer #2708

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

FrankYFTang
Copy link
Contributor

Checklist
  • Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22549
  • Required: The PR title must be prefixed with a JIRA Issue number.
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number.
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

@FrankYFTang FrankYFTang changed the title iICU-22549 Add DateTimePatternGenerator fuzzer ICU-22549 Add DateTimePatternGenerator fuzzer Nov 20, 2023
FrankYFTang added a commit to FrankYFTang/icu that referenced this pull request Nov 20, 2023
@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • icu4c/source/test/fuzzer/date_time_pattern_generator_fuzzer.cpp is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

richgillam
richgillam previously approved these changes Nov 29, 2023
Copy link
Contributor

@richgillam richgillam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll accept that. Thank you for the addition.

@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • icu4c/source/test/fuzzer/Makefile.in is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@richgillam
Copy link
Contributor

What changed since the last time I approved this?

@FrankYFTang
Copy link
Contributor Author

just resolve merge conflict

Copy link
Contributor

@richgillam richgillam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What changed since the last time I approved this?

just resolve merge conflict

Okay. Approved again.

@FrankYFTang
Copy link
Contributor Author

Sorry, my commit message is bad. I need to resquash it again

@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

Copy link
Contributor

@richgillam richgillam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still looks good. :-)

@FrankYFTang FrankYFTang merged commit 0bfa5f4 into unicode-org:main Nov 29, 2023
100 checks passed
@FrankYFTang FrankYFTang deleted the ICU-22549-datePatternGen branch November 29, 2023 22:45
catamorphism pushed a commit to catamorphism/icu that referenced this pull request Jan 2, 2024
catamorphism pushed a commit to catamorphism/icu that referenced this pull request Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants