Skip to content

Commit

Permalink
ICU-22406 Add LIBRARY_DATA_DIR
Browse files Browse the repository at this point in the history
  • Loading branch information
FrankYFTang committed Jun 14, 2023
1 parent ea7ed9a commit f00ff4f
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 3 deletions.
5 changes: 3 additions & 2 deletions icu4c/source/python/icutools/databuilder/__main__.py
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,7 @@ def main(argv):
"IN_DIR": "$(srcdir)",
"INDEX_NAME": "res_index"
}
makefile_env = ["ICUDATA_CHAR", "OUT_DIR", "TMP_DIR"]
makefile_env = ["ICUDATA_CHAR", "OUT_DIR", "TMP_DIR", "LIBRARY_DATA_DIR"]
common = {
key: "$(%s)" % key
for key in list(makefile_vars.keys()) + makefile_env
Expand All @@ -289,7 +289,8 @@ def main(argv):
"CWD_DIR": os.getcwd(),
"INDEX_NAME": "res_index",
# TODO: Pull this from configure script:
"ICUDATA_CHAR": "l"
"ICUDATA_CHAR": "l",
"LIBRARY_DATA_DIR": os.path.join(args.out_dir, "build"),
}

# Automatically load BUILDRULES from the src_dir
Expand Down
2 changes: 1 addition & 1 deletion icu4c/source/test/testdata/BUILDRULES.py
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ def generate_rb(config, io, common_vars):
input_files = [InFile("%s.txt" % bn) for bn in basenames],
output_files = [OutFile("%s.res" % bn) for bn in basenames],
tool = IcuTool("genrb"),
args = "-q -i {OUT_DIR}/../../../../data/out/build -s {IN_DIR} -d {OUT_DIR} {INPUT_FILE}",
args = "-q -i {LIBRARY_DATA_DIR} -s {IN_DIR} -d {OUT_DIR} {INPUT_FILE}",
format_with = {},
repeat_with = {}
),
Expand Down
1 change: 1 addition & 0 deletions icu4c/source/test/testdata/Makefile.in
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@ TESTSRCDATADIR=$(top_srcdir)/test/testdata
TESTOUTDIR=$(top_builddir)/test/testdata/out
BUILD_DIRS = $(TESTOUTDIR) $(TESTBUILDDIR) $(TESTOUTDIR)/$(TESTDT)
GENTEST=$(TOOLDIR)/gentest/gentest$(TOOLEXEEXT)
LIBRARY_DATA_DIR=$(OUTDIR)/build

ifeq ($(PKGDATA_MODE),common)
ICU_DATA_OPT = -i $(OUTDIR)
Expand Down

0 comments on commit f00ff4f

Please sign in to comment.