Skip to content

Commit

Permalink
ICU-22721 Remove now obsolete disabled warnings for LocalPointerBase.
Browse files Browse the repository at this point in the history
The missing operators that used to be warned about were all deleted by
commit 75eab42.
  • Loading branch information
roubert committed Apr 22, 2024
1 parent 0e4c2d8 commit 4c9770f
Show file tree
Hide file tree
Showing 5 changed files with 0 additions and 40 deletions.
8 changes: 0 additions & 8 deletions icu4c/source/i18n/erarules.h
Expand Up @@ -18,16 +18,8 @@ U_NAMESPACE_BEGIN
// When building DLLs for Windows this is required even though no direct access leaks out of the i18n library.
// See digitlst.h, pluralaffix.h, datefmt.h, and others for similar examples.
#if U_PF_WINDOWS <= U_PLATFORM && U_PLATFORM <= U_PF_CYGWIN
#if defined(_MSC_VER)
// Ignore warning 4661 as LocalPointerBase does not use operator== or operator!=
#pragma warning(push)
#pragma warning(disable: 4661)
#endif
template class U_I18N_API LocalPointerBase<int32_t>;
template class U_I18N_API LocalMemory<int32_t>;
#if defined(_MSC_VER)
#pragma warning(pop)
#endif
#endif

class U_I18N_API EraRules : public UMemory {
Expand Down
8 changes: 0 additions & 8 deletions icu4c/source/i18n/measunit_impl.h
Expand Up @@ -356,16 +356,8 @@ template class U_I18N_API MaybeStackVector<MeasureUnitImplWithIndex, 8>;
// Export an explicit template instantiation of the LocalPointer that is used as a
// data member of MeasureUnitImpl.
// (When building DLLs for Windows this is required.)
#if defined(_MSC_VER)
// Ignore warning 4661 as LocalPointerBase does not use operator== or operator!=
#pragma warning(push)
#pragma warning(disable : 4661)
#endif
template class U_I18N_API LocalPointerBase<MeasureUnitImpl>;
template class U_I18N_API LocalPointer<MeasureUnitImpl>;
#if defined(_MSC_VER)
#pragma warning(pop)
#endif
#endif

U_NAMESPACE_END
Expand Down
8 changes: 0 additions & 8 deletions icu4c/source/i18n/number_decimfmtprops.h
Expand Up @@ -21,16 +21,8 @@ U_NAMESPACE_BEGIN
// data member of CurrencyPluralInfoWrapper.
// (When building DLLs for Windows this is required.)
#if U_PF_WINDOWS <= U_PLATFORM && U_PLATFORM <= U_PF_CYGWIN
#if defined(_MSC_VER)
// Ignore warning 4661 as LocalPointerBase does not use operator== or operator!=
#pragma warning(push)
#pragma warning(disable: 4661)
#endif
template class U_I18N_API LocalPointerBase<CurrencyPluralInfo>;
template class U_I18N_API LocalPointer<CurrencyPluralInfo>;
#if defined(_MSC_VER)
#pragma warning(pop)
#endif
#endif

namespace number::impl {
Expand Down
8 changes: 0 additions & 8 deletions icu4c/source/i18n/number_patternmodifier.h
Expand Up @@ -21,16 +21,8 @@ U_NAMESPACE_BEGIN
// data member of AdoptingModifierStore.
// (When building DLLs for Windows this is required.)
#if U_PF_WINDOWS <= U_PLATFORM && U_PLATFORM <= U_PF_CYGWIN
#if defined(_MSC_VER)
// Ignore warning 4661 as LocalPointerBase does not use operator== or operator!=
#pragma warning(push)
#pragma warning(disable : 4661)
#endif
template class U_I18N_API LocalPointerBase<number::impl::AdoptingModifierStore>;
template class U_I18N_API LocalPointer<number::impl::AdoptingModifierStore>;
#if defined(_MSC_VER)
#pragma warning(pop)
#endif
#endif

namespace number::impl {
Expand Down
8 changes: 0 additions & 8 deletions icu4c/source/i18n/number_usageprefs.h
Expand Up @@ -70,16 +70,8 @@ class U_I18N_API UsagePrefsHandler : public MicroPropsGenerator, public UMemory
// Note: These need to be outside of the number::impl namespace, or Clang will
// generate a compile error.
#if U_PF_WINDOWS <= U_PLATFORM && U_PLATFORM <= U_PF_CYGWIN
#if defined(_MSC_VER)
// Ignore warning 4661 as LocalPointerBase does not use operator== or operator!=
#pragma warning(push)
#pragma warning(disable: 4661)
#endif
template class U_I18N_API LocalPointerBase<ComplexUnitsConverter>;
template class U_I18N_API LocalPointer<ComplexUnitsConverter>;
#if defined(_MSC_VER)
#pragma warning(pop)
#endif
#endif

namespace number::impl {
Expand Down

0 comments on commit 4c9770f

Please sign in to comment.