Skip to content

Commit

Permalink
ICU-22534 BRS75 Remove fixed logKnownIssue for CLDR-17024
Browse files Browse the repository at this point in the history
CLDR-17024 is fixed in CLDR45 and the test now passed.
Remove the logKnownIssue so it will test and report future breakage.
  • Loading branch information
FrankYFTang committed Mar 28, 2024
1 parent 070a1f4 commit 0127e4f
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 11 deletions.
3 changes: 1 addition & 2 deletions icu4c/source/test/intltest/tzfmttst.cpp
Expand Up @@ -337,8 +337,7 @@ TimeZoneFormatTest::TestTimeZoneRoundTrip() {
}
} else {
// Specific or generic: raw offset must be preserved.
if (inRaw != outRaw && !(uprv_strncmp(LOCALES[locidx].getName(),"ku",2)==0 && tzid->compare(u"America/Miquelon",16)==0
&& logKnownIssue("CLDR-17024", "TestTimeZoneRoundTrip exhaustive fail with tz=America/Miquelon, locale=ku"))) {
if (inRaw != outRaw) {
errln((UnicodeString)"Raw offset round trip failed; tz=" + *tzid
+ ", locale=" + LOCALES[locidx].getName() + ", pattern=" + PATTERNS[patidx]
+ ", time=" + DATES[datidx] + ", str=" + tzstr
Expand Down
Expand Up @@ -274,8 +274,7 @@ public void TestTimeZoneRoundTrip() {
}
} else {
// Specific or generic: raw offset must be preserved.
if (inOffsets[0] != outOffsets[0] && !(LOCALES[locidx].getName().startsWith("ku") && tzids[tzidx].equals("America/Miquelon")
&& logKnownIssue("CLDR-17024", "TestTimeZoneRoundTrip exhaust. fail with tz=America/Miquelon, locale=ku"))) {
if (inOffsets[0] != outOffsets[0] ) {
if (JDKTZ && tzids[tzidx].startsWith("SystemV/")) {
// JDK uses rule SystemV for these zones while
// ICU handles these zones as aliases of existing time zones
Expand Down Expand Up @@ -426,13 +425,6 @@ && logKnownIssue("11052", "Ambiguous zone name - Samoa Time")) {
continue;
}

if ((id.equals("America/Miquelon") || id.equals("America/Hermosillo") || id.equals("America/Mazatlan"))
&& PATTERNS[patidx].equals("v")
&& LOCALES[locidx].getName().startsWith("ku")
&& logKnownIssue("CLDR-17024", "TestTimeRoundTrip fail with tz=America/Miquelon, pattern=v, locale=ku")) {
continue;
}

BasicTimeZone btz = (BasicTimeZone)TimeZone.getTimeZone(id, TimeZone.TIMEZONE_ICU);
TimeZone tz = TimeZone.getTimeZone(id);
sdf.setTimeZone(tz);
Expand Down

0 comments on commit 0127e4f

Please sign in to comment.