CLDR-6746 TestPaths to include seed and exemplars #604
Conversation
|
It's normally intended, but there are exceptions for entities that behave
as a(complex) unit.
…On Sat, Aug 1, 2020, 23:04 Steven R. Loomis ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In seed/rbnf/nci.xml
<#604 (comment)>:
> @@ -11,7 +11,7 @@ For terms of use, see https://www.unicode.org/copyright.html
<language type="nci"/>
</identity>
<rbnf>
- <rulesetGrouping type="SpelloutRules" draft="unconfirmed">
The better choice is to add rulesetGrouping to
DtdData.DRAFT_ON_NON_LEAF_ALLOWED
Ok great thanks. I had assumed the behavior was intended, but will fix.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#604 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACJLEMAKN35KMHRLSSZP3WLR6T6W3ANCNFSM4PRD4H6Q>
.
|
|
@macchiati new error message (will be fixed by updating DtdData):
But, 3e1fdaa in CLDR-9228 explicitly set deprecated unless this change to the dtd was an error, I've changed this to respect |
|
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
There was a problem hiding this comment.
Looks ok except for needing a different change than adding a test in case "@deprecated".
| @@ -224,7 +224,10 @@ public void addComment(String commentIn) { | |||
| attributeStatus = AttributeStatus.value; | |||
| break; | |||
| case "@DEPRECATED": | |||
| isDeprecatedAttribute = true; | |||
| if (!name.equals("draft") | |||
There was a problem hiding this comment.
For the others ("collation", "transform", "unitPreferenceData") I think we explicitly removed the @deprecated on the element, which is cleaner than having this special test.
(There is no particular value to distinguishing the "with-children" case from the "without children" case.)
|
Ok so in short: fix the DTD to remove the depreciation from rulesetGrouping?
…On Mon, Aug 3, 2020 at 2:32 PM Mark Davis ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Looks ok except for needing a different change than adding a test in case "
@deprecated <https://github.com/deprecated>".
------------------------------
In tools/java/org/unicode/cldr/util/DtdData.java
<#604 (comment)>:
> @@ -224,7 +224,10 @@ public void addComment(String commentIn) {
attributeStatus = AttributeStatus.value;
break;
case ***@***.***":
- isDeprecatedAttribute = true;
+ if (!name.equals("draft")
For the others ("collation", "transform", "unitPreferenceData") I think we
explicitly removed the @deprecated <https://github.com/deprecated> on the
element, which is cleaner than having this special test.
(There is no particular value to distinguishing the "with-children" case
from the "without children" case.)
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#604 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGQZM7M7N6IY7QTSFYP5ELR64UGXANCNFSM4PRD4H6Q>
.
|
DTD/Tools - fix the DTD to not deprecate draft= on rulesetGrouping - fix DtdData to include rulesetGrouping in DRAFT_ON_NON_LEAF_ALLOWED Test changes: - TestPaths needed to include seed and exemplars - update TestPaths to print a more helpful message Data changes: (seed) - update sa collation to not use a deprecated attribute
|
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
CLDR-6746
I moved the normalization mode out of the deprecated options, and removed the deprecated draftiness on RBNF.