CLDR-13862 Add length preference for usage focal-length #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added the ticket to the agenda for next week. |
sffc
previously approved these changes
Aug 7, 2020
|
Kip, you'll need to squash the ticket to fix the commit message before this can be merged. |
|
@kipcole9 Are you planning on rewriting the commit message to CLDR format so we can merge this PR? |
|
Apologies, I will Squash the commits in the next 24 hours.
…Sent from my iPhone
On 25 Aug 2020, at 23:24, Shane F. Carr ***@***.***> wrote:
@kipcole9 Are you planning on rewriting the commit message to CLDR format so we can merge this PR?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
|
Commits squash and I believe RTM. Please advise is any other changes are required,
… On 25 Aug 2020, at 11:24 pm, Shane F. Carr ***@***.***> wrote:
@kipcole9 <https://github.com/kipcole9> Are you planning on rewriting the commit message to CLDR format so we can merge this PR?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#506 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAD4F55DSOVS4IQCYEITEDSCPJR3ANCNFSM4NYY244A>.
|
macchiati
approved these changes
Aug 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add unit preference category
length, usagefocal-length