CLDR-14943 cldrsplain: refactor VoteResolver code, add API #2480
Conversation
04c0592
to
9f4493a
Compare
|
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
| annotateTranscript("- This is the winning value because it comes earlier than '%s' when the text was sorted, though the weight was otherwise equal to the next-best.", nValue); | ||
| } | ||
| annotateTranscript("The Next-best (N) value is '%s', with weight %d", nValue, N); | ||
| } |
There was a problem hiding this comment.
minor quibble: better if subroutine is below its caller
There was a problem hiding this comment.
in this case however it's intentionally adjacent to votesThenUcaCollator.compare
ideally the annotateTranscript calls might be inside votesThenUcaCollator.compare itself?
There was a problem hiding this comment.
Right.
It can't be inside the collator because actually we don't annotate every comparison, just the top two.
There was a problem hiding this comment.
the collator could call a method that has a boolean to turn on annotation; boolean false when the collator calls it, boolean true when this method calls it just for the top two
| @@ -929,6 +929,10 @@ public void clear() { | |||
| oValue = null; | |||
| winningValue = null; | |||
| nValue = null; | |||
|
|
|||
| if(transcript != null) { | |||
There was a problem hiding this comment.
minor minor quibble: java needs formatting
| ); | ||
| transcriptBox.appendChild(transcriptNote); | ||
| tr.voteDiv.appendChild(transcriptBox); | ||
| } |
There was a problem hiding this comment.
but as i mentioned this is a preview… there may be ways to visualize the data better, however, i want to make sure i'm getting the right data first.
9f4493a
to
efecc3a
Compare
|
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
- for now, include transcript with each row - add in Info Panel
520f2d6
to
280d793
Compare
CLDR-14943