CLDR-10384 Use display names for Organization menus #2477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-New cldrOrganizations.js encapsulates org names on front end -Sort org display names alphabetically on front end with localeCompare -List Users and Add User menus are alphabetically sorted by org display name -List Users sections are alphabetically sorted by org display name -Fix form-validation problems in AddUser.vue, wait until levels and orgs are loaded -Fix AddUser.vue, clear errors and warnings when Add Another User -In cldrAccount.js always get orgs; even for a single org, need short/display mapping -In cldrAccount.js new setMockLevels, setMockOrgs for unit testing without json from server -In AddUser.java, use Auth.SESSION_HEADER not query param s -In OrgList.java, respond with both short and display org names -In OrgList.java, do not share Organization.special (High Coverage and Generated) with the front end -In UserList.java, do not include org list in json, no longer needed -Comments
srl295
approved these changes
Oct 21, 2022
| // Note: this assignment to levelList is redundant except for the unit test; | ||
| // a future revision of the unit test could supply a mock levelList separately | ||
| levelList = json.userPerms.levels; | ||
| shownUsers = json.shownUsers; // redundant except for unit test |
| @@ -143,4 +143,8 @@ public LocaleSet getCoveredLocales() { | |||
| } | |||
| return localeSet; | |||
| } | |||
|
|
|||
| public boolean visibleOnFrontEnd() { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-New cldrOrganizations.js encapsulates org names on front end
-Sort org display names alphabetically on front end with localeCompare
-List Users and Add User menus are alphabetically sorted by org display name
-List Users sections are alphabetically sorted by org display name
-Fix form-validation problems in AddUser.vue, wait until levels and orgs are loaded
-Fix AddUser.vue, clear errors and warnings when Add Another User
-In cldrAccount.js always get orgs; even for a single org, need short/display mapping
-In cldrAccount.js new setMockLevels, setMockOrgs for unit testing without json from server
-In AddUser.java, use Auth.SESSION_HEADER not query param s
-In OrgList.java, respond with both short and display org names
-In OrgList.java, do not share Organization.special (High Coverage and Generated) with the front end
-In UserList.java, do not include org list in json, no longer needed
-Comments
CLDR-10384