CLDR-15161 progress: back end for locale completion(3) #1638

srl295 · 2021-12-01T15:57:07Z

CLDR-15161 progress: back end for locale completion (third meter)

enable third meter in cldrProgress.js
back end API for LocaleCompletion
test case for LocaleCompletion, including minor changes to enable
testability of STFactory-related code.
This PR completes the ticket.

srl295 · 2021-12-01T15:58:32Z

Not quite working yet, but some progress

verify that all errors (even comprehensive) are counted
check M/P at the specified level

Grabacion.de.pantalla.2021-12-01.a.la.s.9.45.13.a.m.mov

jira-pull-request-webhook · 2021-12-01T18:44:13Z

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

jira-pull-request-webhook · 2021-12-02T19:45:34Z

Notice: the branch changed across the force-push!

tools/cldr-apps/js/src/esm/cldrProgress.js is different
tools/cldr-apps/src/main/java/org/unicode/cldr/util/SandboxLocales.java is different
tools/cldr-apps/src/main/java/org/unicode/cldr/web/api/LocaleCompletion.java is different
tools/cldr-apps/src/test/java/org/unicode/cldr/web/api/TestLocaleCompletion.java is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

srl295 · 2021-12-02T19:48:18Z

tools/cldr-apps/src/test/java/org/unicode/cldr/web/api/TestLocaleCompletion.java

+ // ** Step two.
+ // Make some changes, and we should have a couple of errors.
+ // "Expected <100%"
+ // Mutate
+ localeFile.add("//ldml/characters/exemplarCharacters", "[]");
+ localeFile.add("//ldml/numbers/symbols[@numberSystem=\"latn\"]/group",
+ ",,,"); // err; expected 1, not 3
+ // rootFile.add("//ldml/localeDisplayNames/languages/language[@type=\""+TEST_LOCALE+"\"]",
+ // TEST_LOCALE); // for fallback
+ localeFile.remove("//ldml/localeDisplayNames/languages/language[@type=\"" + TEST_LOCALE + "\"]");
+ localeFile.add("//ldml/dates/timeZoneNames/zone[@type=\"Pacific/Kanton\"]/exemplarCity[@draft=\"provisional\"]", "cabaca");
+ localeFile.add("//ldml/dates/timeZoneNames/zone[@type=\"Asia/Qyzylorda\"]/exemplarCity[@draft=\"unconfirmed\"]", "bacaba");
+ tc.invalidateAllCached();
+ final int EXPECT_ERROR = 2;
+ final int EXPECT_MISSING = 1;
+ final int EXPECT_PROVISIONAL = 2;


The above results in 2 errors, 1 missing, 2 provisional.

The front end doesn't need the M/E/P split out, but it's useful for debugging.

srl295 · 2021-12-02T20:03:39Z

random failing tests notwithstanding, I am still not getting the right behavior from this. It shows more work to do when nothing shows up in the dashboard.

Leaving this in draft.

jira-pull-request-webhook · 2021-12-02T22:12:55Z

Notice: the branch changed across the force-push!

.vscode/launch.json is now changed in the branch
tools/cldr-apps/src/main/java/org/unicode/cldr/web/api/LocaleCompletion.java is different
tools/cldr-apps/src/main/java/org/unicode/cldr/web/api/STError.java is now changed in the branch

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

jira-pull-request-webhook · 2021-12-02T22:13:16Z

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

jira-pull-request-webhook · 2021-12-10T01:14:35Z

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

jira-pull-request-webhook · 2021-12-10T21:46:49Z

Notice: the branch changed across the force-push!

tools/cldr-apps/src/main/java/org/unicode/cldr/web/api/LocaleCompletion.java is different
tools/cldr-apps/src/main/java/org/unicode/cldr/web/STFactory.java is now changed in the branch
tools/cldr-apps/src/test/java/org/unicode/cldr/web/api/TestLocaleCompletion.java is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

srl295 · 2021-12-10T21:47:48Z

Think this is ready.

srl295 · 2021-12-10T21:48:17Z

tools/cldr-apps/src/test/java/org/unicode/cldr/web/api/TestLocaleCompletion.java

+ localeFile.add("//ldml/numbers/currencies/currency[@type=\"XTS\"]/displayName[@draft=\"provisional\"]",
+ "Test Currency (comprehensive level, should not have an effect on completion)");
+ localeFile.add("//ldml/numbers/currencies/currency[@type=\"XUA\"]/displayName[@draft=\"unconfirmed\"]",
+ "Other Test Currency (comprehensive level, should not have an effect on completion)");


Ignored due to limited submission, but tested to work otherwise.

btangmu · 2021-12-13T16:12:59Z

tools/cldr-apps/src/test/java/org/unicode/cldr/web/api/TestLocaleCompletion.java

+ private static final String TEST_LOCALE = "es";
+
+ @Test
+ void testLocaleCompletion() throws SQLException, IOException {


this function is too long, even for a unit test

btangmu · 2021-12-13T16:26:42Z

@srl295 one concern is that I haven't yet done what Mark proposed last week: make the 2nd meter visible but grayed out when the dash data hasn't been fetched. Without that, the 3rd meter will sometimes be the 2nd visible meter. That might be confusing. I'll work on the grayed-out 2nd meter today. In the meantime, I wonder if we should merge this except keep CAN_GET_LOCALE_PROGRESS = false? Then I'd be able to test locally with all 3 meters. If there's no push to production today or tomorrow, then CAN_GET_LOCALE_PROGRESS = true is fine and will enable testing on smoketest; maybe it's fine anyway; what do you think?

srl295 · 2021-12-13T16:43:33Z

@srl295 one concern is that I haven't yet done what Mark proposed last week: make the 2nd meter visible but grayed out when the dash data hasn't been fetched. Without that, the 3rd meter will sometimes be the 2nd visible meter. That might be confusing. I'll work on the grayed-out 2nd meter today. In the meantime, I wonder if we should merge this except keep CAN_GET_LOCALE_PROGRESS = false? Then I'd be able to test locally with all 3 meters. If there's no push to production today or tomorrow, then CAN_GET_LOCALE_PROGRESS = true is fine and will enable testing on smoketest; maybe it's fine anyway; what do you think?

I filed CLDR-15239 to get these switches out of source.

Sure, i will change it to false…

- back end API for LocaleCompletion - test case for LocaleCompletion, including minor changes to enable testability of STFactory-related code. - update launch.json to improve attaching to OpenLiberty - return 503 error if the SurveyTool is not yet started - Ignore some paths per Phase and SubmissionLocales

jira-pull-request-webhook · 2021-12-13T16:51:07Z

Notice: the branch changed across the force-push!

tools/cldr-apps/js/src/esm/cldrProgress.js is different
tools/cldr-apps/src/test/java/org/unicode/cldr/web/api/TestLocaleCompletion.java is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

btangmu · 2021-12-13T17:16:10Z

uh-oh: "cldrTable.cldrChecksum
should be fast enough:
AssertionError: Duration was 101 ms; 1000 iterations should take less than 100 ms"
I'll restart the test; really that test (my fault) should be disabled or made into a warning

btangmu · 2021-12-13T18:26:34Z

@srl295 let's go ahead and merge this, ok?

srl295 self-assigned this Dec 1, 2021

srl295 force-pushed the cldr-15161/locale2 branch from 8d13dfe to fa0cb7a Compare December 1, 2021 18:44

srl295 force-pushed the cldr-15161/locale2 branch from c68ad65 to 4bd76b0 Compare December 2, 2021 19:45

srl295 requested review from btangmu and macchiati December 2, 2021 19:46

srl295 commented Dec 2, 2021

View reviewed changes

srl295 marked this pull request as ready for review December 2, 2021 19:48

srl295 changed the title ~~CLDR-15161 wip back end for locale completion~~ CLDR-15161 progress: back end for locale completion(3) Dec 2, 2021

srl295 marked this pull request as draft December 2, 2021 20:01

srl295 force-pushed the cldr-15161/locale2 branch from 4bd76b0 to 773b09e Compare December 2, 2021 22:12

srl295 force-pushed the cldr-15161/locale2 branch from 773b09e to f2a938a Compare December 2, 2021 22:13

srl295 force-pushed the cldr-15161/locale2 branch from f2a938a to 142f5f0 Compare December 10, 2021 01:14

srl295 force-pushed the cldr-15161/locale2 branch from ae1bf50 to aa88512 Compare December 10, 2021 21:46

srl295 marked this pull request as ready for review December 10, 2021 21:47

srl295 commented Dec 10, 2021

View reviewed changes

btangmu reviewed Dec 13, 2021

View reviewed changes

srl295 force-pushed the cldr-15161/locale2 branch from aa88512 to 0348714 Compare December 13, 2021 16:51

srl295 requested a review from btangmu December 13, 2021 16:51

btangmu approved these changes Dec 13, 2021

View reviewed changes

srl295 merged commit 686de2b into unicode-org:main Dec 13, 2021

srl295 deleted the cldr-15161/locale2 branch December 13, 2021 18:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CLDR-15161 progress: back end for locale completion(3) #1638

CLDR-15161 progress: back end for locale completion(3) #1638

srl295 commented Dec 1, 2021 •

edited

Loading

srl295 commented Dec 1, 2021 •

edited

Loading

jira-pull-request-webhook bot commented Dec 1, 2021

jira-pull-request-webhook bot commented Dec 2, 2021

srl295 Dec 2, 2021

srl295 commented Dec 2, 2021

jira-pull-request-webhook bot commented Dec 2, 2021

jira-pull-request-webhook bot commented Dec 2, 2021

jira-pull-request-webhook bot commented Dec 10, 2021

jira-pull-request-webhook bot commented Dec 10, 2021

srl295 commented Dec 10, 2021

srl295 Dec 10, 2021

btangmu Dec 13, 2021

btangmu commented Dec 13, 2021

srl295 commented Dec 13, 2021

jira-pull-request-webhook bot commented Dec 13, 2021

btangmu commented Dec 13, 2021

btangmu commented Dec 13, 2021

CLDR-15161 progress: back end for locale completion(3) #1638

CLDR-15161 progress: back end for locale completion(3) #1638

Conversation

srl295 commented Dec 1, 2021 • edited Loading

srl295 commented Dec 1, 2021 • edited Loading

jira-pull-request-webhook bot commented Dec 1, 2021

jira-pull-request-webhook bot commented Dec 2, 2021

srl295 Dec 2, 2021

Choose a reason for hiding this comment

srl295 commented Dec 2, 2021

jira-pull-request-webhook bot commented Dec 2, 2021

jira-pull-request-webhook bot commented Dec 2, 2021

jira-pull-request-webhook bot commented Dec 10, 2021

jira-pull-request-webhook bot commented Dec 10, 2021

srl295 commented Dec 10, 2021

srl295 Dec 10, 2021

Choose a reason for hiding this comment

btangmu Dec 13, 2021

Choose a reason for hiding this comment

btangmu commented Dec 13, 2021

srl295 commented Dec 13, 2021

jira-pull-request-webhook bot commented Dec 13, 2021

btangmu commented Dec 13, 2021

btangmu commented Dec 13, 2021

srl295 commented Dec 1, 2021 •

edited

Loading

srl295 commented Dec 1, 2021 •

edited

Loading