Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase timout period while reducing number of retries #17

Merged
merged 2 commits into from
Jun 9, 2023
Merged

Conversation

fbpe
Copy link
Contributor

@fbpe fbpe commented Jun 8, 2023

  • Increase sleep time between consecutive retries from 100 milliseconds to 1 second
  • Decrease number of retries from 100 to 60.
  • Add verification for number of approvals left

Closes #16

@fbpe fbpe requested a review from jmini June 8, 2023 14:54
Copy link
Contributor

@jmini jmini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@fbpe fbpe merged commit f238172 into main Jun 9, 2023
2 checks passed
@fbpe fbpe deleted the issue-16 branch June 9, 2023 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase timeout or number of retries to accept a MR
2 participants