Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: settings billing issues for selfhosted #584

Merged
merged 1 commit into from
Aug 31, 2024
Merged

fix: settings billing issues for selfhosted #584

merged 1 commit into from
Aug 31, 2024
+52 −10

Conversation

McPizza0
Copy link
Member

@McPizza0 McPizza0 commented Jul 20, 2024 •
edited by BlankParticle

What does this PR do?

Don't show billing related stuff if billing is not available

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • Enhancement (small improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

Required

  • Read Contributing Guide
  • Self-reviewed my own code
  • Tested my code in a local environment
  • Commented on my code in hard-to-understand areas
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the UnInbox Docs if changes were necessary

@McPizza0 McPizza0 mentioned this pull request Jul 20, 2024
Merged
16 tasks
@McPizza0 Graphite App
Copy link
Member Author

McPizza0 commented Jul 20, 2024 •
edited by BlankParticle

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @McPizza0 and the rest of your teammates on Graphite Graphite

@McPizza0 McPizza0 force-pushed the fix-settings-billing-selfhosted branch from d4d71d5 to d409015 Compare July 21, 2024 22:10
@McPizza0 McPizza0 force-pushed the fix-settings-billing-selfhosted branch from d409015 to 1963fc2 Compare July 23, 2024 19:45
@McPizza0 McPizza0 force-pushed the fix-settings-billing-selfhosted branch from 1963fc2 to 5d9200b Compare July 23, 2024 22:10
@McPizza0 McPizza0 force-pushed the feat_spaces branch 4 times, most recently from 8b5aa99 to a9831ee Compare July 26, 2024 17:08
@BlankParticle BlankParticle force-pushed the fix-settings-billing-selfhosted branch from 5d9200b to 24bdecd Compare July 28, 2024 15:48
@BlankParticle BlankParticle force-pushed the fix-settings-billing-selfhosted branch from 24bdecd to f1a0788 Compare July 28, 2024 16:02
@BlankParticle BlankParticle force-pushed the fix-settings-billing-selfhosted branch from f1a0788 to 50dc2fe Compare July 28, 2024 16:26
@McPizza0 McPizza0 force-pushed the feat_spaces branch 2 times, most recently from 5d2e4d5 to e9b3c55 Compare July 30, 2024 17:01
@McPizza0 McPizza0 force-pushed the feat_spaces branch 3 times, most recently from a3b3fb4 to 0e827ea Compare August 8, 2024 07:32
@McPizza0 McPizza0 mentioned this pull request Aug 8, 2024
Merged
@McPizza0 McPizza0 force-pushed the feat_spaces branch 2 times, most recently from b9fb9b8 to 389dfd6 Compare August 11, 2024 19:16
@McPizza0 McPizza0 mentioned this pull request Aug 11, 2024
Merged
@McPizza0 McPizza0 mentioned this pull request Aug 12, 2024
Closed
16 tasks
@BlankParticle BlankParticle force-pushed the feat_spaces branch 4 times, most recently from ba2c508 to 7131a4e Compare August 21, 2024 13:19
Base automatically changed from feat_spaces to main August 21, 2024 13:23
@BlankParticle BlankParticle force-pushed the fix-settings-billing-selfhosted branch 2 times, most recently from f5f4e95 to 5c4fbcb Compare August 30, 2024 19:06
@BlankParticle BlankParticle marked this pull request as ready for review August 30, 2024 19:06
@BlankParticle BlankParticle force-pushed the fix-settings-billing-selfhosted branch from 5c4fbcb to 75d13cb Compare August 30, 2024 19:08
@BlankParticle BlankParticle changed the title fix-settings-billing-selfhosted fix: settings billing issues for selfhosted Aug 30, 2024
@BlankParticle BlankParticle self-requested a review August 30, 2024 19:08
@BlankParticle BlankParticle force-pushed the fix-settings-billing-selfhosted branch from 75d13cb to 1f069b0 Compare August 30, 2024 19:09
@BlankParticle
Copy link
Member

@McPizza0, I have updated the PR, you might want to take a look

@BlankParticle BlankParticle force-pushed the fix-settings-billing-selfhosted branch from 1f069b0 to e754fc1 Compare August 31, 2024 04:01
@BlankParticle BlankParticle merged commit 04d31f6 into main Aug 31, 2024
5 checks passed
@BlankParticle BlankParticle deleted the fix-settings-billing-selfhosted branch August 31, 2024 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BlankParticle BlankParticle BlankParticle approved these changes

Assignees

@McPizza0 McPizza0

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@McPizza0 @BlankParticle