fix: git setup user name should use GITLAB_CI_USER_NAME #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
🦋 Changeset detectedLatest commit: 82de629 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
AdrielLimanthie
force-pushed
the
fix/git-setup-user-name
branch
from
84523cb
to
bfb4bd4
Compare
|
Should it fallback to |
Yeah, that makes sense. I'll add that in. |
AdrielLimanthie
force-pushed
the
fix/git-setup-user-name
branch
from
bfb4bd4
to
f9740fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raising this PR as I found a bug in the git setup when setting user name.
As mentioned in the README.md, you should be able to set git user name by specifying variable
GITLAB_CI_USER_NAME. But the current code gets the user name fromGITLAB_USER_NAMEinstead, which is a predefined Gitlab variable. Thus, setting variableGITLAB_CI_USER_NAMEactually does nothing.This PR fixes the issue by changing the code to use
GITLAB_CI_USER_NAMEinstead for the git user name.