Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use git commit -A #42

Merged
merged 1 commit into from
Feb 17, 2022
Merged

fix: use git commit -A #42

merged 1 commit into from
Feb 17, 2022

Conversation

pmjhonwang
Copy link
Contributor

@pmjhonwang pmjhonwang commented Feb 9, 2022

@changeset-bot
Copy link

changeset-bot bot commented Feb 9, 2022

🦋 Changeset detected

Latest commit: 935ee9c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
changesets-gitlab Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 9, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@pmjhonwang
Copy link
Contributor Author

@JounQin CR Request pls

@JounQin
Copy link
Member

JounQin commented Feb 14, 2022

@pmjhonwang Sorry I didn't notice this PR previously.

But I'm just wondering why are you using so old git version? Is GitLab old too?

@pmjhonwang
Copy link
Contributor Author

pmjhonwang commented Feb 14, 2022

@pmjhonwang Sorry I didn't notice this PR previously.

But I'm just wondering why are you using so old git version? Is GitLab old too?

some gitlab runner and docker image is too old, but I have no permission to upgrade them!

CleanShot 2022-02-15 at 01 44 19@2x

git add . is equal to git add -A .

git add . with git 1.x, will have no delete files in .changest/xxxx.md, so release MR is wrong!

maybe i should use git add -A . when check git version is 1.x

@JounQin
Copy link
Member

JounQin commented Feb 15, 2022

@pmjhonwang It seems git add -A is already fine enough, no need git add -A .

@pmjhonwang
Copy link
Contributor Author

pmjhonwang commented Feb 15, 2022

@pmjhonwang It seems git add -A is already fine enough, no need git add -A .

CleanShot 2022-02-15 at 15 06 14@2x

add path is more clear

@pmjhonwang
Copy link
Contributor Author

should these pr be merged?

@JounQin JounQin merged commit a6f751a into un-ts:main Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants