Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix known issues, add other token types support #23

Merged
merged 11 commits into from
Nov 22, 2021

Conversation

HosseinAgha
Copy link
Contributor

@HosseinAgha HosseinAgha commented Nov 7, 2021

This resolves #21, resolves #22, resolves #24, and resolves #25.

The issue with the comment command was that the checking for the previous comment was not strict enough and it was trying to update a system note (by the MR owner). So if I pushed to the MR a system note would be generated and changesets-gitlab would accidentally try to updated that comment.

I've also added a prepack script so future contributors can use the raw Github repository as a dependency.

I've also added a new option to provide CIJob or OAuth token (gitbeaker actually supports this), although looks like ci-job-token access is very limited so only oauth token is usable until this Gitlab MR merges.

@changeset-bot
Copy link

changeset-bot bot commented Nov 7, 2021

🦋 Changeset detected

Latest commit: 32d974b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
changesets-gitlab Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 7, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@HosseinAgha HosseinAgha force-pushed the fix-21-22 branch 2 times, most recently from 5e1e605 to f86f6d7 Compare November 15, 2021 12:25
@HosseinAgha HosseinAgha changed the title feat: add job token and oauth token support fix: changeset comment issue Nov 20, 2021
@HosseinAgha
Copy link
Contributor Author

@JounQin
This is a major bug in the package's functionality.
Could you please merge it?

@HosseinAgha HosseinAgha force-pushed the fix-21-22 branch 2 times, most recently from 1036358 to 563c07f Compare November 20, 2021 22:17
@JounQin
Copy link
Member

JounQin commented Nov 21, 2021

Sorry, I didn’t notice this PR before, I’ll check ASAP.

@JounQin
Copy link
Member

JounQin commented Nov 21, 2021

I've also added a prepack script so future contributors can use the raw Github repository as a dependency.

I'm not sure how it's working and why we should support installing git repo.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
src/comment.ts Outdated Show resolved Hide resolved
src/gitUtils.ts Outdated Show resolved Hide resolved
src/run.ts Outdated Show resolved Hide resolved
@JounQin
Copy link
Member

JounQin commented Nov 21, 2021

@HosseinAgha Thanks for your effort first, I have a few questions above, maybe it can be separated into a few PRs instead for discussion.

For example, fixing the missing dependencies seems very correct to me.

@HosseinAgha
Copy link
Contributor Author

I've also added a prepack script so future contributors can use the raw Github repository as a dependency.

I'm not sure how it's working and why we should support installing git repo.

It is just a convenience for future contributors so they can directly install their PR branch in their projects and test their changes.
After adding this I can add my branch as a package like the following:

{
  "changesets-gitlab": "github:HosseinAgha/changesets-gitlab#head=fix-21-22"
}

yarn (and npm) will run the prepack script after cloning my version of changesets-gitlab so I can use the built version of the package.

@JounQin
Copy link
Member

JounQin commented Nov 21, 2021

@HosseinAgha We have codesanbox support, see https://ci.codesandbox.io/status/rx-ts/changesets-gitlab/pr/23/builds/190422 for details.

README.md Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/run.ts Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Member

@JounQin JounQin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address my nitpicky comments.

@JounQin JounQin changed the title fix: changeset comment issue fix known issues, add other token types support Nov 22, 2021
@JounQin JounQin merged commit 9e6cb95 into un-ts:main Nov 22, 2021
@HosseinAgha
Copy link
Contributor Author

Thanks @JounQin ❤️

lluiscab added a commit to lluiscab/changesets-gitlab that referenced this pull request Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants