Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): migrate to @gitbeaker/rest #138

Merged
merged 8 commits into from
Nov 17, 2023
Merged

fix(deps): migrate to @gitbeaker/rest #138

merged 8 commits into from
Nov 17, 2023

Conversation

alan910127
Copy link
Contributor

Closes #131

Summary

  • Remove the usage of @gitbeaker/node and use @gitbeaker/rest instead.

Copy link

changeset-bot bot commented Nov 17, 2023

🦋 Changeset detected

Latest commit: a574a34

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
changesets-gitlab Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

src/index.ts Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
src/index.ts Show resolved Hide resolved
src/utils.ts Outdated Show resolved Hide resolved
@JounQin
Copy link
Member

JounQin commented Nov 17, 2023

image

- 14
- 16
- 18

@alan910127 Please help to change these node versions at the same time.

For codesandbox, we can use 18, for GitHub Actions, we should use 18 and 20

@alan910127
Copy link
Contributor Author

image https://github.com/un-ts/changesets-gitlab/blob/a30d2babda63e0bd49ef3123671cc7c062ab663d/.codesandbox/ci.json#L2

- 14
- 16
- 18

@alan910127 Please help to change these node versions at the same time.

For codesandbox, we can use 18, for GitHub Actions, we should use 18 and 20

How about the release action in .github/workflows/release.yml? Should I also bump it to node 18?

Copy link

codesandbox-ci bot commented Nov 17, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@JounQin
Copy link
Member

JounQin commented Nov 17, 2023

How about the release action in .github/workflows/release.yml? Should I also bump it to node 18?

We can change to use lts/*

.github/workflows/ci.yml Outdated Show resolved Hide resolved
src/utils.ts Outdated Show resolved Hide resolved
@JounQin JounQin merged commit be50e4a into un-ts:main Nov 17, 2023
4 checks passed
@JounQin
Copy link
Member

JounQin commented Nov 17, 2023

@alan910127 Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecated package gitbeaker/node
2 participants