Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add the path to the origin url #120

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

Rkaede
Copy link
Contributor

@Rkaede Rkaede commented Aug 23, 2023

When gitlab is hosted in a nested path (e.g. http:https://www.company.com/gitlab) the release MR creation would fail because it would try and fetch the repo without the path (/gitlab) in the origin URL.

This MR adds the path to the origin url.

@stackblitz
Copy link

stackblitz bot commented Aug 23, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@changeset-bot
Copy link

changeset-bot bot commented Aug 23, 2023

🦋 Changeset detected

Latest commit: f8ed6f5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
changesets-gitlab Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@JounQin
Copy link
Member

JounQin commented Aug 23, 2023

Thanks for your contribution first! Are you trying to fix #116?

@JounQin JounQin merged commit f35cd64 into un-ts:main Aug 23, 2023
4 of 5 checks passed
@Rkaede
Copy link
Contributor Author

Rkaede commented Aug 23, 2023

I was getting the exact same error as #116 but the cirsumstances described there is different.

It looks as though the gitlab instance in that issue is hosted at the root path (/) so this MR is unlikely to make a difference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants