Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fallback GITLAB_HOST to CI_SERVER_URL #113

Merged
merged 5 commits into from
Aug 3, 2023

Conversation

Wxh16144
Copy link
Contributor

@Wxh16144 Wxh16144 commented Aug 3, 2023

backround: #112 (comment)

@stackblitz
Copy link

stackblitz bot commented Aug 3, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@changeset-bot
Copy link

changeset-bot bot commented Aug 3, 2023

🦋 Changeset detected

Latest commit: 81093cc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
changesets-gitlab Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 3, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@Wxh16144
Copy link
Contributor Author

Wxh16144 commented Aug 3, 2023

src/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
@JounQin
Copy link
Member

JounQin commented Aug 3, 2023

Hi, @Wxh16144 , thanks for your contribution! Please fix the CI issues first.

@Wxh16144
Copy link
Contributor Author

Wxh16144 commented Aug 3, 2023

Hi, @Wxh16144 , thanks for your contribution! Please fix the CI issues first.

I don't speak English very well, but seeing that you are also Chinese, can I reply you in Chinese?
我英文不太好, 看到你也是华人, 我可以用中文回复你吗?

@JounQin JounQin merged commit f8ae011 into un-ts:main Aug 3, 2023
4 of 5 checks passed
@JounQin JounQin changed the title refacort: improve code logic to increase robustness feat: fallback GITLAB_HOST to CI_SERVER_URL Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants